Class: Rubocop::Cop::Rails::IncludeUrlHelper
- Inherits:
-
RuboCop::Cop::Base
- Object
- RuboCop::Cop::Base
- Rubocop::Cop::Rails::IncludeUrlHelper
- Defined in:
- lib/rubocop/cop/rails/include_url_helper.rb
Constant Summary collapse
- MSG =
<<~MSG Avoid including `ActionView::Helpers::UrlHelper`. It adds/overrides ~40 methods while usually only one is needed. Instead, use the `Gitlab::Routing.url_helpers`/`Application.routes.url_helpers`(outside of gitlab) and `ActionController::Base.helpers.link_to`. See https://gitlab.com/gitlab-org/gitlab/-/issues/340567. MSG
Instance Method Summary collapse
Instance Method Details
#include_url_helpers_node?(node) ⇒ Object
16 17 18 |
# File 'lib/rubocop/cop/rails/include_url_helper.rb', line 16 def_node_matcher :include_url_helpers_node?, <<~PATTERN (send nil? :include (const (const (const {nil? cbase} :ActionView) :Helpers) :UrlHelper)) PATTERN |
#on_send(node) ⇒ Object
20 21 22 |
# File 'lib/rubocop/cop/rails/include_url_helper.rb', line 20 def on_send(node) add_offense(node) if include_url_helpers_node?(node) end |