Class: RuboCop::Cop::Chef::Modernize::SimplifyAptPpaSetup

Inherits:
Base
  • Object
show all
Extended by:
AutoCorrector
Includes:
RangeHelp, RuboCop::Chef::CookbookHelpers
Defined in:
lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb

Overview

The apt_repository resource allows setting up PPAs without using the full URL to ppa.launchpad.net, which should be used to simplify the resource code in your cookbooks.

Examples:


### incorrect
  apt_repository 'atom-ppa' do
    uri 'http://ppa.launchpad.net/webupd8team/atom/ubuntu'
    components ['main']
    keyserver 'keyserver.ubuntu.com'
    key 'C2518248EEA14886'
  end

### correct
  apt_repository 'atom-ppa' do
    uri 'ppa:webupd8team/atom'
    components ['main']
    keyserver 'keyserver.ubuntu.com'
    key 'C2518248EEA14886'
  end

Constant Summary collapse

MSG = 
'The apt_repository resource allows setting up PPAs without using the full URL to ppa.launchpad.net.'

Instance Method Summary collapse

Methods included from RuboCop::Chef::CookbookHelpers

#match_property_in_resource?, #match_resource_type?, #method_arg_ast_to_string, #resource_block_name_if_string

Methods inherited from Base

#target_chef_version

Instance Method Details

#on_block(node) ⇒ Object 



49
50
51
52
53
54
55
56
57
58
 
# File 'lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb', line 49

def on_block(node)
  match_property_in_resource?(:apt_repository, 'uri', node) do |uri|
    if %r{http(s)*://ppa.launchpad.net/(.*)/ubuntu$}.match?(uri.arguments&.first&.str_content)
      add_offense(uri, severity: :refactor) do |corrector|
        next unless (replacement_val = %r{http(s)*://ppa.launchpad.net/(.*)/ubuntu}.match(node.source)[2])
        corrector.replace(uri, "uri 'ppa:#{replacement_val}'")
      end
    end
  end
end