Class: RuboCop::Cop::Chef::Modernize::ExecuteAptUpdate

Inherits:
Base
  • Object
show all
Extended by:
AutoCorrector
Defined in:
lib/rubocop/cop/chef/modernize/execute_apt_update.rb

Overview

Instead of using the execute resource to run the ‘apt-get update` use Chef Infra Client’s built-n apt_update resource which is available in Chef Infra Client 12.7 and later.

Examples:


### incorrect
execute 'apt-get update'

execute 'Apt all the apt cache' do
  command 'apt-get update'
end

execute 'some execute resource' do
  notifies :run, 'execute[apt-get update]', :immediately
end

### correct
apt_update

apt_update 'update apt cache'

execute 'some execute resource' do
  notifies :update, 'apt_update[update apt cache]', :immediately
end

Constant Summary collapse

MSG = 
'Use the apt_update resource instead of the execute resource to run an apt-get update package cache update'
RESTRICT_ON_SEND = 
[:execute, :notifies, :subscribes, :command].freeze

Instance Method Summary collapse

Methods inherited from Base

#target_chef_version

Instance Method Details

#on_send(node) ⇒ Object 



64
65
66
67
68
69
70
71
72
73
74
75
76
 
# File 'lib/rubocop/cop/chef/modernize/execute_apt_update.rb', line 64

def on_send(node)
  execute_apt_update?(node) do
    add_offense(node, severity: :refactor)
  end

  notification_property?(node) do |val|
    add_offense(val, severity: :refactor) if val.str_content&.start_with?('execute[apt-get update]')
  end

  execute_command?(node) do |val|
    add_offense(node, severity: :refactor) if val.str_content == 'apt-get update'
  end
end