Module: Carson::Runtime::Review

Includes:
DataAccess, GateSupport, QueryText, SweepSupport, Utility
Included in:
Carson::Runtime
Defined in:
lib/carson/runtime/review.rb,
lib/carson/runtime/review/utility.rb,
lib/carson/runtime/review/query_text.rb,
lib/carson/runtime/review/data_access.rb,
lib/carson/runtime/review/gate_support.rb,
lib/carson/runtime/review/sweep_support.rb

Overview

PR review gate and sweep workflow.

Defined Under Namespace

Modules: DataAccess, GateSupport, QueryText, SweepSupport, Utility

Instance Method Summary collapse

Instance Method Details

#review_gate! ⇒ Object 



18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
 
# File 'lib/carson/runtime/review.rb', line 18

def review_gate!
	fingerprint_status = block_if_outsider_fingerprints!
	return fingerprint_status unless fingerprint_status.nil?
	puts_verbose ""
	puts_verbose "[Review Gate]"
	unless verbose?
		puts_line "Review Gate"
	end
	unless gh_available?
		puts_line "ERROR: gh CLI not available in PATH."
		return EXIT_ERROR
	end

	owner, repo = repository_coordinates
	pr_number_override = carson_pr_number_override
	pr_summary =
		if pr_number_override.nil?
			current_pull_request_for_branch( branch_name: current_branch )
		else
			details = pull_request_details( owner: owner, repo: repo, pr_number: pr_number_override )
			{
				number: details.fetch( :number ),
				title: details.fetch( :title ),
				url: details.fetch( :url ),
				state: details.fetch( :state )
			}
		end
	if pr_summary.nil?
		puts_line "BLOCK: no pull request found for branch #{current_branch}."
		report = {
			generated_at: Time.now.utc.iso8601,
			branch: current_branch,
			status: "block",
			converged: false,
			wait_seconds: config.review_wait_seconds,
			poll_seconds: config.review_poll_seconds,
			max_polls: config.review_max_polls,
			block_reasons: [ "no pull request found for current branch" ],
			pr: nil,
			unresolved_threads: [],
			actionable_top_level: [],
			unacknowledged_actionable: []
		}
		write_review_gate_report( report: report )
		return EXIT_BLOCK
	end

	pre_snapshot = wait_for_review_warmup( owner: owner, repo: repo, pr_number: pr_summary.fetch( :number ) )
	converged = false
	last_snapshot = pre_snapshot
	last_signature = pre_snapshot.nil? ? nil : review_gate_signature( snapshot: pre_snapshot )
	poll_attempts = 0

	config.review_max_polls.times do |index|
		poll_attempts = index + 1
		snapshot = review_gate_snapshot( owner: owner, repo: repo, pr_number: pr_summary.fetch( :number ) )
		last_snapshot = snapshot
		signature = review_gate_signature( snapshot: snapshot )
		puts_verbose "poll_attempt: #{poll_attempts}/#{config.review_max_polls}"
		puts_verbose "latest_activity: #{snapshot.fetch( :latest_activity ) || 'unknown'}"
		puts_verbose "unresolved_threads: #{snapshot.fetch( :unresolved_threads ).count}"
		puts_verbose "unacknowledged_actionable: #{snapshot.fetch( :unacknowledged_actionable ).count}"
		if !last_signature.nil? && signature == last_signature
			converged = true
			puts_verbose "convergence: stable"
			break
		end
		last_signature = signature
		wait_for_review_poll if index < config.review_max_polls - 1
	end

	block_reasons = []
	block_reasons << "review snapshot did not converge within #{config.review_max_polls} polls" unless converged
	if last_snapshot.fetch( :unresolved_threads ).any?
		block_reasons << "unresolved review threads remain (#{last_snapshot.fetch( :unresolved_threads ).count})"
	end
	if last_snapshot.fetch( :unacknowledged_actionable ).any?
		block_reasons << "actionable top-level comments/reviews without required disposition (#{last_snapshot.fetch( :unacknowledged_actionable ).count})"
	end

	report = {
		generated_at: Time.now.utc.iso8601,
		branch: current_branch,
		status: block_reasons.empty? ? "ok" : "block",
		converged: converged,
		wait_seconds: config.review_wait_seconds,
		poll_seconds: config.review_poll_seconds,
		max_polls: config.review_max_polls,
		poll_attempts: poll_attempts,
		block_reasons: block_reasons,
		pr: {
			number: pr_summary.fetch( :number ),
			title: pr_summary.fetch( :title ),
			url: pr_summary.fetch( :url ),
			state: pr_summary.fetch( :state )
		},
		unresolved_threads: last_snapshot.fetch( :unresolved_threads ),
		actionable_top_level: last_snapshot.fetch( :actionable_top_level ),
		unacknowledged_actionable: last_snapshot.fetch( :unacknowledged_actionable )
	}
	write_review_gate_report( report: report )
	unless verbose?
		puts_line "Polling... (converged after #{poll_attempts} attempt#{plural_suffix( count: poll_attempts )})"
	end
	if block_reasons.empty?
		puts_line "OK: review gate passed."
		return EXIT_OK
	end
	block_reasons.each { |reason| puts_line "BLOCK: #{reason}" }
	EXIT_BLOCK
rescue JSON::ParserError => exception
	puts_line "ERROR: invalid gh JSON response (#{exception.message})."
	EXIT_ERROR
rescue StandardError => exception
	puts_line "ERROR: #{exception.message}"
	EXIT_ERROR
end

#review_sweep! ⇒ Object

Scheduled sweep for late actionable review activity across recent pull requests.



137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
 
# File 'lib/carson/runtime/review.rb', line 137

def review_sweep!
	fingerprint_status = block_if_outsider_fingerprints!
	return fingerprint_status unless fingerprint_status.nil?
	puts_verbose ""
	puts_verbose "[Review Sweep]"
	unless gh_available?
		puts_line "ERROR: gh CLI not available in PATH."
		return EXIT_ERROR
	end

	owner, repo = repository_coordinates
	cutoff_time = Time.now.utc - ( config.review_sweep_window_days * 86_400 )
	pull_requests = recent_pull_requests_for_sweep( owner: owner, repo: repo, cutoff_time: cutoff_time )
	puts_verbose "window_days: #{config.review_sweep_window_days}"
	puts_verbose "candidate_prs: #{pull_requests.count}"
	findings = []

	pull_requests.each do |entry|
		next unless config.review_sweep_states.include?( sweep_state_for( pr_state: entry.fetch( :state ) ) )
		details = pull_request_details( owner: owner, repo: repo, pr_number: entry.fetch( :number ) )
		findings.concat( sweep_findings_for_pull_request( details: details ) )
	end

	findings.sort_by! { |item| [ item.fetch( :pr_number ), item.fetch( :created_at ).to_s, item.fetch( :url ) ] }
	issue_result = upsert_review_sweep_tracking_issue( owner: owner, repo: repo, findings: findings )
	report = {
		generated_at: Time.now.utc.iso8601,
		status: findings.empty? ? "ok" : "block",
		window_days: config.review_sweep_window_days,
		states: config.review_sweep_states,
		cutoff_time: cutoff_time.utc.iso8601,
		candidate_count: pull_requests.count,
		finding_count: findings.count,
		findings: findings,
		tracking_issue: issue_result
	}
	write_review_sweep_report( report: report )
	puts_line "finding_count: #{findings.count}"
	if findings.empty?
		puts_line "OK: no actionable late review activity detected."
		return EXIT_OK
	end
	puts_line "BLOCK: actionable late review activity detected."
	EXIT_BLOCK
rescue JSON::ParserError => exception
	puts_line "ERROR: invalid gh JSON response (#{exception.message})."
	EXIT_ERROR
rescue StandardError => exception
	puts_line "ERROR: #{exception.message}"
	EXIT_ERROR
end