Class: Brakeman::CheckSelectVulnerability

Inherits:
BaseCheck
  • Object
show all
Defined in:
lib/brakeman/checks/check_select_vulnerability.rb

Overview

Checks for select() helper vulnerability in some versions of Rails 3 http://groups.google.com/group/rubyonrails-security/browse_thread/thread/9da0c515a6c4664

Instance Method Summary collapse

Instance Method Details

#process_result(result) ⇒ Object 



37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
 
# File 'lib/brakeman/checks/check_select_vulnerability.rb', line 37

def process_result result
  return if duplicate? result

  third_arg = result[:call].third_arg

  #Check for user input in options parameter
  if sexp? third_arg and include_user_input? third_arg
    add_result result

    if string_interp? third_arg
      confidence = :medium
    else
      confidence = :weak
    end

    warn :template => result[:location][:template],
        :warning_type => "Cross-Site Scripting",
        :warning_code => :select_options_vuln,
        :result => result,
        :message => @message,
        :confidence => confidence,
        :cwe_id => [79]
  end
end

#run_check ⇒ Object 



10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
 
# File 'lib/brakeman/checks/check_select_vulnerability.rb', line 10

def run_check

  if lts_version? "2.3.18.7"
    return
  elsif version_between? "3.0.0", "3.0.11"
    suggested_version = "3.0.12"
  elsif version_between? "3.1.0", "3.1.3"
    suggested_version = "3.1.4"
  elsif version_between? "3.2.0", "3.2.1"
    suggested_version = "3.2.2"
  elsif version_between? "2.0.0", "2.3.14"
    suggested_version = "3 or use options_for_select"
  else
    return
  end

  @message = msg("Upgrade to ", msg_version(suggested_version), ". In ", msg_version(rails_version), " ", msg_code("select"), " helper is vulnerable")

  calls = tracker.find_call(:target => nil, :method => :select).select do |result|
    result[:location][:type] == :template
  end

  calls.each do |result|
    process_result result
  end
end